Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8317299: safepoint scalarization doesn't keep track of the depth of the JVM state #74

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 28, 2024

Hi all,

This pull request contains a backport of commit 6d911f68 from the openjdk/jdk repository.

The commit being backported was authored by Damon Fenacci on 6 Feb 2024 and was reviewed by Tobias Hartmann and Vladimir Ivanov.

Thanks!


Progress

  • JDK-8317299 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317299: safepoint scalarization doesn't keep track of the depth of the JVM state (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/74/head:pull/74
$ git checkout pull/74

Update a local copy of the PR:
$ git checkout pull/74
$ git pull https://git.openjdk.org/jdk22u.git pull/74/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 74

View PR using the GUI difftool:
$ git pr show -t 74

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/74.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6d911f68a3244c40a62ab2570dfec68b8d0ed5d8 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317299: safepoint scalarization doesn't keep track of the depth of the JVM state

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 29, 2024
@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

Going to push as commit dd4dc38.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b73c15e: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
  • 78df8c1: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • 1a2b122: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • aeb85fd: 8325326: [PPC64] Don't relocate in case of allocation failure
  • e3ae81e: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2024
@openjdk openjdk bot closed this Mar 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@TobiHartmann Pushed as commit dd4dc38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant