Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8187759: Background not refreshed when painting over a transparent JFrame #77

Conversation

Renjithkannath
Copy link
Contributor

@Renjithkannath Renjithkannath commented Feb 28, 2024

Backporting the fix which fixes Background painting issue over a transparent JFrame.
Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8187759 needs maintainer approval

Issue

  • JDK-8187759: Background not refreshed when painting over a transparent JFrame (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.org/jdk22u.git pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/77.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 04d43c435d3ede519df169053dd9d724aa2312eb 8187759: Background not refreshed when painting over a transparent JFrame Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @Renjithkannath This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@Renjithkannath usage: /approval [<id>] (request|cancel) [<text>]

@Renjithkannath
Copy link
Contributor Author

/approval request Clean backport

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@Renjithkannath
8187759: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8187759: Background not refreshed when painting over a transparent JFrame

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • b2275aa: 8325730: StringBuilder.toString allocation for the empty String
  • fd11382: 8324834: Use _LARGE_FILES on AIX
  • f510fe8: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 6b307d7: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • f5cfcbb: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • cffdef1: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 6ac9326: 8327391: Add SipHash attribution file
  • cebe57d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • 648a161: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • d6fc2b1: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • ... and 8 more: https://git.openjdk.org/jdk22u/compare/a8cd7fa592d7a28fcd63d851de53c85618d62492...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 8, 2024
@Renjithkannath
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@Renjithkannath
Your change (at version 3d1aedf) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit 244c1d8.
Since your change was applied there have been 18 commits pushed to the master branch:

  • b2275aa: 8325730: StringBuilder.toString allocation for the empty String
  • fd11382: 8324834: Use _LARGE_FILES on AIX
  • f510fe8: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 6b307d7: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • f5cfcbb: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • cffdef1: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 6ac9326: 8327391: Add SipHash attribution file
  • cebe57d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • 648a161: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • d6fc2b1: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • ... and 8 more: https://git.openjdk.org/jdk22u/compare/a8cd7fa592d7a28fcd63d851de53c85618d62492...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@aivanov-jdk @Renjithkannath Pushed as commit 244c1d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants