8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread

[vpa1977]

Hi all,

This pull request contains a backport of commit d1099033 from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 8 Feb 2024 and was reviewed by Brian Burkhalter.

This change fixes a bug in jruby[1] that broken pipeline functions of Open3[1][2].

Thanks!

[1] jruby/jruby#8069
[2] https://bugs.launchpad.net/ubuntu/+source/jruby/+bug/2054943

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325028 needs maintainer approval

Issue

• JDK-8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/79/head:pull/79
$ git checkout pull/79

Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.org/jdk22u.git pull/79/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 79

View PR using the GUI difftool:
$ git pr show -t 79

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/79.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (b1c3d969)

[vpa1977]

GHA failure setting up RISCV schroot.

[openjdk]

⚠️ @vpa1977 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[vpa1977]

@GoeLin Hi, I have removed fix request due to the broken RISCV sysroot .
The error that I am getting:

W: See /home/runner/work/jdk22u/jdk22u/sysroot/debootstrap/debootstrap.log for details (possibly the package /var/cache/apt/archives/libssl3t64_3.1.5-1.1_riscv64.deb is at fault)

hints at RISCV being affected by time_t transition currently going on in Debian.

This will be an issue for the next few weeks.

[vpa1977]

/approval request

[openjdk]

@vpa1977
8325028: The approval request has been created successfully.

[openjdk]

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 22230b3: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 3d6bd8e: 8328604: remove on_aix() function
• 92d6fa4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
• 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
• 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
• 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
• 95772e6: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
• 5d7f7da: 8325567: jspawnhelper without args fails with segfault
• 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
• 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
• ... and 44 more: https://git.openjdk.org/jdk22u/compare/a8cd7fa592d7a28fcd63d851de53c85618d62492...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[vpa1977]

/integrate

[openjdk]

@vpa1977
Your change (at version b1c3d96) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit dbaca7a.
Since your change was applied there have been 57 commits pushed to the master branch:

• 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
• 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
• 98a63a8: 8328589: unify os::breakpoint among posix platforms
• 22230b3: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 3d6bd8e: 8328604: remove on_aix() function
• 92d6fa4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
• 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
• 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
• 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
• 95772e6: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
• ... and 47 more: https://git.openjdk.org/jdk22u/compare/a8cd7fa592d7a28fcd63d851de53c85618d62492...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @vpa1977 Pushed as commit dbaca7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.