Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8327391: Add SipHash attribution file #85

Closed

Conversation

JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Mar 5, 2024

Clean backport


Progress

  • Change must not contain extraneous whitespace
  • JDK-8327391 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8327391: Add SipHash attribution file (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/85/head:pull/85
$ git checkout pull/85

Update a local copy of the PR:
$ git checkout pull/85
$ git pull https://git.openjdk.org/jdk22u.git pull/85/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 85

View PR using the GUI difftool:
$ git pr show -t 85

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/85.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2024

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 8327391: Add SipHash attribution file Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

⚠️ @JesperIRL This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2024

Webrevs

@JesperIRL
Copy link
Member Author

/approval request Clean backport of required attribution file

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@JesperIRL
8327391: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327391: Add SipHash attribution file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • cebe57d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • 648a161: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • d6fc2b1: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 324d7cc: 8327467: Bump version numbers for 22.0.2
  • 882978f: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 7, 2024
@JesperIRL
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

Going to push as commit 6ac9326.
Since your change was applied there have been 5 commits pushed to the master branch:

  • cebe57d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • 648a161: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • d6fc2b1: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 324d7cc: 8327467: Bump version numbers for 22.0.2
  • 882978f: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2024
@openjdk openjdk bot closed this Mar 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@JesperIRL Pushed as commit 6ac9326.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant