Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8320005: Allow loading of shared objects with .a extension on AIX #87

Conversation

suchismith1993
Copy link

@suchismith1993 suchismith1993 commented Mar 6, 2024

Hi all,

This pull request contains a backport of commit e85355ad from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320005 needs maintainer approval

Issue

  • JDK-8320005: Allow loading of shared objects with .a extension on AIX (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/87/head:pull/87
$ git checkout pull/87

Update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.org/jdk22u.git pull/87/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 87

View PR using the GUI difftool:
$ git pr show -t 87

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/87.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2024

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab 8320005: Allow loading of shared objects with .a extension on AIX Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2024

Webrevs

@suchismith1993
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@suchismith1993 usage: /approval [<id>] (request|cancel) [<text>]

@suchismith1993
Copy link
Author

/approval request This back port is required to handle dynamic libraries of AIX.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@suchismith1993
8320005: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@suchismith1993 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320005: Allow loading of shared objects with .a extension on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • fd11382: 8324834: Use _LARGE_FILES on AIX
  • f510fe8: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 6b307d7: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • f5cfcbb: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • cffdef1: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 6ac9326: 8327391: Add SipHash attribution file
  • cebe57d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • 648a161: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • d6fc2b1: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 324d7cc: 8327467: Bump version numbers for 22.0.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 8, 2024
@suchismith1993
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@suchismith1993
Your change (at version 7f5ec76) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit 2e5c300.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 9b52a00: 8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX
  • 244c1d8: 8187759: Background not refreshed when painting over a transparent JFrame
  • b2275aa: 8325730: StringBuilder.toString allocation for the empty String
  • fd11382: 8324834: Use _LARGE_FILES on AIX
  • f510fe8: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 6b307d7: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • f5cfcbb: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • cffdef1: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 6ac9326: 8327391: Add SipHash attribution file
  • cebe57d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • ... and 3 more: https://git.openjdk.org/jdk22u/compare/882978f646f27168d17a908a61c8eaa0c7a08481...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@TheRealMDoerr @suchismith1993 Pushed as commit 2e5c300.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants