8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations

[zifeihan]

Hi, The same issue also exists in the JDK22U: I can reproduce it locally and use this clean patch can fix that issue, So I would like to backport this to JDK22U. Several related tests failed before this patch, including gc/shenandoah/TestSmallHeap.java, gc/metaspace/TestMetaspacePerfCounters.java#Shenandoah-64, etc. After the fix, it can passed normally. This is a risc-v specific change. Backport is clean, risk is low.

I see that GHA linux-cross-compile / build (riscv64) fails, but I can build it successfully locally. GHA failure is infrastructural: https://bugs.openjdk.org/browse/JDK-8326960

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326936 needs maintainer approval

Issue

• JDK-8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/90/head:pull/90
$ git checkout pull/90

Update a local copy of the PR:
$ git checkout pull/90
$ git pull https://git.openjdk.org/jdk22u.git pull/90/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 90

View PR using the GUI difftool:
$ git pr show -t 90

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/90.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (2e72dd33)

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 6ac9326: 8327391: Add SipHash attribution file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[zifeihan]

/integrate

[openjdk]

@zifeihan
Your change (at version 2e72dd3) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit cffdef1.
Since your change was applied there has been 1 commit pushed to the master branch:

• 6ac9326: 8327391: Add SipHash attribution file

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit cffdef1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.