Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX #92

Closed

Conversation

JoKern65
Copy link

@JoKern65 JoKern65 commented Mar 8, 2024

Hi all,

This pull request contains a backport of commit 997e615c from the openjdk/jdk repository.

The commit being backported was authored by Joachim Kern on 8 Mar 2024 and was reviewed by Guoxiong Li and Thomas Stuefe.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322943 needs maintainer approval

Issue

  • JDK-8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/92/head:pull/92
$ git checkout pull/92

Update a local copy of the PR:
$ git checkout pull/92
$ git pull https://git.openjdk.org/jdk22u.git pull/92/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 92

View PR using the GUI difftool:
$ git pr show -t 92

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/92.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2024

👋 Welcome back jkern! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 997e615c69f4445d92e164b814ea3358659e93dc 8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

⚠️ @JoKern65 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2024

Webrevs

@JoKern65
Copy link
Author

JoKern65 commented Mar 8, 2024

/approval JDK-8322943 request Backport of fix for AIX. No risk, clean backport.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@JoKern65
JDK-8322943: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@JoKern65 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 244c1d8: 8187759: Background not refreshed when painting over a transparent JFrame
  • b2275aa: 8325730: StringBuilder.toString allocation for the empty String
  • fd11382: 8324834: Use _LARGE_FILES on AIX
  • f510fe8: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 6b307d7: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • f5cfcbb: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@JoKern65
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@JoKern65
Your change (at version 0701557) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit 9b52a00.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 244c1d8: 8187759: Background not refreshed when painting over a transparent JFrame
  • b2275aa: 8325730: StringBuilder.toString allocation for the empty String
  • fd11382: 8324834: Use _LARGE_FILES on AIX
  • f510fe8: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 6b307d7: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • f5cfcbb: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@MBaesken @JoKern65 Pushed as commit 9b52a00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants