8324646: Avoid Class.forName in SecureRandom constructor

[olivergillespie]

Hi all,

This pull request contains a backport of commit 8ef918d6 from the openjdk/jdk repository.

The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324646 needs maintainer approval

Issue

• JDK-8324646: Avoid Class.forName in SecureRandom constructor (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/98/head:pull/98
$ git checkout pull/98

Update a local copy of the PR:
$ git checkout pull/98
$ git pull https://git.openjdk.org/jdk22u.git pull/98/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 98

View PR using the GUI difftool:
$ git pr show -t 98

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/98.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @olivergillespie This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (ac8e8e14)

[olivergillespie]

Benchmark results (make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench):

Before: 2833 ± 61 ns/op
 After: 2229 ± 157 ns/op

(note that this combines well with #99 to bring the total down to ~100ns)

[olivergillespie]

/approval request Performance improvement in SecureRandom.<init>, which I have seen on the hot path in real applications. Clean backport, low risk in my opinion (simple change to only one file). It has been in tip for around 4 weeks. Confirmed the benchmark results match tip (saves 600ns in SecureRandom constructor).

[openjdk]

@olivergillespie
8324646: The approval request has been created successfully.

[openjdk]

@olivergillespie This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324646: Avoid Class.forName in SecureRandom constructor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• afce5e6: 8322503: Shenandoah: Clarify gc state usage
• 6c2eefc: 8326529: JFR: Test for CompilerCompile events fails due to time out
• 2ec72f9: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection
• 82c3743: 8326496: [test] checkHsErrFileContent support printing hserr in error case
• 6aa344a: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case
• b8fa711: 8325432: enhance assert message "relocation addr must be in this section"
• 0c6f3bd: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
• a99aa0e: 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64
• 2e5c300: 8320005: Allow loading of shared objects with .a extension on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[olivergillespie]

/integrate

[openjdk]

@olivergillespie
Your change (at version ac8e8e1) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 5cb863d.
Since your change was applied there have been 21 commits pushed to the master branch:

• 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
• f2e1be5: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
• 8888745: 8328705: GHA: Cross-compilation jobs do not require build JDK
• ba80d42: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960
• 2c00048: 8328812: Update and move siphash license
• dcca5da: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
• 14bd76f: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
• 089aad7: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap
• 5b3e566: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
• c90dd21: 8328165: improve assert(idx < _maxlrg) failed: oob
• ... and 11 more: https://git.openjdk.org/jdk22u/compare/9b52a0093980ed245a51e859d4f9ed94d90796b3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @olivergillespie Pushed as commit 5cb863d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.