Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

8332524: Instead of printing "TLSv1.3," it is showing "TLS13" #10

Closed
wants to merge 1 commit into from

Conversation

nibjen
Copy link
Contributor

@nibjen nibjen commented Jun 26, 2024

Clean backport of JDK-8332524


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332524 needs maintainer approval

Issue

  • JDK-8332524: Instead of printing "TLSv1.3," it is showing "TLS13" (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.org/jdk23u.git pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/10.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2024

👋 Welcome back nibjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@nibjen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332524: Instead of printing "TLSv1.3," it is showing "TLS13"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e681b4e9b3ae24f45d8c6adab4105df39e6b8a92 8332524: Instead of printing "TLSv1.3," it is showing "TLS13" Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Jun 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

⚠️ @nibjen the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8332524
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 27, 2024
@nibjen
Copy link
Contributor Author

nibjen commented Jun 27, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@nibjen
Your change (at version 353e9e3) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Jun 27, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

Going to push as commit 9449a53.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2024
@openjdk openjdk bot closed this Jun 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@coffeys @nibjen Pushed as commit 9449a53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants