Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 19, 2024

Backporting JDK-8340210 to 23u.

This pull request contains a backport of commit f0ae90f3 from the openjdk/jdk repository.

The commit being backported was authored by Harshitha Onkar on 17 Sep 2024 and was reviewed by Alexey Ivanov and Alexander Zvegintsev.


Progress

  • JDK-8340210 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340210: Add positionTestUI() to PassFailJFrame.Builder (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/106/head:pull/106
$ git checkout pull/106

Update a local copy of the PR:
$ git checkout pull/106
$ git pull https://git.openjdk.org/jdk23u.git pull/106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 106

View PR using the GUI difftool:
$ git pr show -t 106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/106.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340210: Add positionTestUI() to PassFailJFrame.Builder

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • ac8e8da: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate
  • 3e84943: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
  • 227fc46: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64
  • f7d38e1: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f0ae90f30c346544e87217ef1832d6a350fe1985 8340210: Add positionTestUI() to PassFailJFrame.Builder Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

⚠️ @aivanov-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 19, 2024
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2024

Going to push as commit faa89f4.
Since your change was applied there have been 20 commits pushed to the master branch:

  • b8d01b0: 8340308: PassFailJFrame: Make rows default to number of lines in instructions
  • fa008de: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS
  • e4badd4: 8340007: Refactor KeyEvent/FunctionKeyTest.java
  • 20c1153: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout
  • caf28d4: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5
  • 54bb851: 8338389: [JFR] Long strings should be added to the string pool
  • 5979904: 8337876: [IR Framework] Add support for IR tests with @stable
  • 547a229: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
  • c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
  • 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
  • ... and 10 more: https://git.openjdk.org/jdk23u/compare/bf45fbdc1dbbd4c93dff79b2d6984f5a3e3e5df2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2024
@openjdk openjdk bot closed this Sep 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2024
@openjdk
Copy link

openjdk bot commented Sep 27, 2024

@aivanov-jdk Pushed as commit faa89f4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant