8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS

[aivanov-jdk]

Backporting JDK-8332901 to 23u.

The patch does not apply cleanly, there's a conflict in test/jdk/ProblemList.txt because of context differences. JDK 23u does not have the Wayland related problem-listings.

Essentially, the change to ProblemList.txt is the same: remove SelectNewItemTest.java from PL.

This pull request contains a backport of commit ef96a7b0 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 4 Sep 2024 and was reviewed by Harshitha Onkar, Phil Race and Damon Nguyen.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8332901 needs maintainer approval

Issue

• JDK-8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/107/head:pull/107
$ git checkout pull/107

Update a local copy of the PR:
$ git checkout pull/107
$ git pull https://git.openjdk.org/jdk23u.git pull/107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 107

View PR using the GUI difftool:
$ git pr show -t 107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/107.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS

Move SelectCurrentItemTest.java to java/awt/Choice/SelectItem/.
Move SelectNewItemTest.java to java/awt/Choice/SelectItem/.
Use latches to control test flow instead of delays.
Encapsulate the common logic in SelectCurrentItemTest.
Provide overridable checkXXX() methods to modify conditions.
Provide an overridable method which defines where to click
in the choice popup to select an item.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• ac8e8da: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate
• 3e84943: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
• 227fc46: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64
• f7d38e1: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

⚠️ @aivanov-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (9b52b378)

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit fa008de.
Since your change was applied there have been 18 commits pushed to the master branch:

• e4badd4: 8340007: Refactor KeyEvent/FunctionKeyTest.java
• 20c1153: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout
• caf28d4: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5
• 54bb851: 8338389: [JFR] Long strings should be added to the string pool
• 5979904: 8337876: [IR Framework] Add support for IR tests with @stable
• 547a229: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• a21db48: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds
• 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject
• ... and 8 more: https://git.openjdk.org/jdk23u/compare/bf45fbdc1dbbd4c93dff79b2d6984f5a3e3e5df2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit fa008de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.