8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5

[matias9927]

Backport of the changes JDK-8338924 and JDK-8335664. This patch is not clean since it excludes the changes to Problem list.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8338924 needs maintainer approval
• Commit message must refer to an issue
• JDK-8335664 needs maintainer approval

Issues

• JDK-8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 (Bug - P4 - Approved)
• JDK-8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds (Bug - P4 - Approved)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/109/head:pull/109
$ git checkout pull/109

Update a local copy of the PR:
$ git checkout pull/109
$ git pull https://git.openjdk.org/jdk23u.git pull/109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 109

View PR using the GUI difftool:
$ git pr show -t 109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/109.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5
8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 54bb851: 8338389: [JFR] Long strings should be added to the string pool
• 5979904: 8337876: [IR Framework] Add support for IR tests with @stable
• 547a229: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• a21db48: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds
• 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 127a68a: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
• 73313ef: 8334229: Optimize InterpreterOopMap layout
• a6754f3: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
• ... and 3 more: https://git.openjdk.org/jdk23u/compare/227fc468a4d04c75e677a270b274b998f33b5e8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[matias9927]

/issue add JDK-8335664

[openjdk]

@matias9927
Adding additional issue to issue list: 8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds.

[mlbridge]

Webrevs

• 00: Full (fb0bb05f)

[coleenp]

Looks good!

[openjdk]

⚠️ @matias9927 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[matias9927]

/approval request

[openjdk]

@matias9927
8338924: The approval request has been created successfully.
8335664: The approval request has been created successfully.

[matias9927]

Thank you for the review @coleenp !
/integrate

[openjdk]

@matias9927
Your change (at version fb0bb05) is now ready to be sponsored by a Committer.

[coleenp]

/sponsor

[openjdk]

Going to push as commit caf28d4.
Since your change was applied there have been 13 commits pushed to the master branch:

• 54bb851: 8338389: [JFR] Long strings should be added to the string pool
• 5979904: 8337876: [IR Framework] Add support for IR tests with @stable
• 547a229: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• a21db48: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds
• 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 127a68a: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
• 73313ef: 8334229: Optimize InterpreterOopMap layout
• a6754f3: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
• ... and 3 more: https://git.openjdk.org/jdk23u/compare/227fc468a4d04c75e677a270b274b998f33b5e8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp @matias9927 Pushed as commit caf28d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.