-
Notifications
You must be signed in to change notification settings - Fork 62
8334653: ISO 4217 Amendment 177 Update #13
8334653: ISO 4217 Amendment 177 Update #13
Conversation
👋 Welcome back wxiao! A progress list of the required criteria for merging this PR into |
@weibxiao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval |
@weibxiao usage: |
@weibxiao can you please follow up on this request? I see that the change is already backported to lower JDK update releases, so I want to make sure it gets in to jdk23u as well. Thanks. |
Sure. I will follow up. I only know Rob M is one of maintainer. He is on vacation now. I am going to leave a message for me in Slack chat. |
/integrate |
@weibxiao This pull request has not yet been marked as ready for integration. |
/approval request iso4217 for 177 update |
/approve yes |
@naotoj Only integrators for this repository are allowed to issue the |
/integrate |
/sponsor |
Going to push as commit bbbfb7f.
Your commit was automatically rebased without conflicts. |
@RealCLanger @weibxiao Pushed as commit bbbfb7f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport ISO 4217 for 177 update to jdk23u
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/13/head:pull/13
$ git checkout pull/13
Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jdk23u.git pull/13/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13
View PR using the GUI difftool:
$ git pr show -t 13
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/13.diff
Webrev
Link to Webrev Comment