Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8334653: ISO 4217 Amendment 177 Update #13

Conversation

weibxiao
Copy link

@weibxiao weibxiao commented Jul 1, 2024

Backport ISO 4217 for 177 update to jdk23u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334653 needs maintainer approval

Issue

  • JDK-8334653: ISO 4217 Amendment 177 Update (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/13/head:pull/13
$ git checkout pull/13

Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jdk23u.git pull/13/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13

View PR using the GUI difftool:
$ git pr show -t 13

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/13.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2024

👋 Welcome back wxiao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@weibxiao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334653: ISO 4217 Amendment 177 Update

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 2723ffa: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • 9a4fc09: Merge
  • e5fbc63: 8326820: Metadata artificially kept alive
  • e78c682: 8333849: (dc) DatagramChannel send/receive fails with UOE if buffer backed by memory segment allocated from shared arena
  • 87a2962: 8335220: C2: Missing check for Opaque4 node in EscapeAnalysis
  • 32ed615: 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop
  • 62d0ee9: 8334421: assert(!oldbox->is_unbalanced()) failed: this should not be called for unbalanced region
  • 98fd657: 8326705: Test CertMsgCheck.java fails to find alert certificate_required
  • d7b9454: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved
  • b5fbdb2: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538
  • ... and 7 more: https://git.openjdk.org/jdk23u/compare/d494c21b9b4589916a1ee1a33b9bcaa5a6479601...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 86b0cf259fb3cbe3a1973151148e5d36c6a99d91 8334653: ISO 4217 Amendment 177 Update Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

⚠️ @weibxiao This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2024

Webrevs

@weibxiao
Copy link
Author

weibxiao commented Jul 1, 2024

/approval

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@weibxiao usage: /approval [<id>] (request|cancel) [<text>]

@RealCLanger
Copy link
Contributor

@weibxiao can you please follow up on this request? I see that the change is already backported to lower JDK update releases, so I want to make sure it gets in to jdk23u as well. Thanks.

@openjdk openjdk bot added the approval label Jul 5, 2024
@weibxiao
Copy link
Author

weibxiao commented Jul 5, 2024

Sure. I will follow up. I only know Rob M is one of maintainer. He is on vacation now. I am going to leave a message for me in Slack chat.

@weibxiao
Copy link
Author

weibxiao commented Jul 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@weibxiao This pull request has not yet been marked as ready for integration.

@weibxiao
Copy link
Author

weibxiao commented Jul 5, 2024

/approval request iso4217 for 177 update

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@weibxiao
8334653: The approval request has been created successfully.

@naotoj
Copy link
Member

naotoj commented Jul 5, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@naotoj Only integrators for this repository are allowed to issue the /approve command.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 5, 2024
@weibxiao
Copy link
Author

weibxiao commented Jul 8, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 8, 2024
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@weibxiao
Your change (at version 4127787) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

Going to push as commit bbbfb7f.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 2723ffa: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • 9a4fc09: Merge
  • e5fbc63: 8326820: Metadata artificially kept alive
  • e78c682: 8333849: (dc) DatagramChannel send/receive fails with UOE if buffer backed by memory segment allocated from shared arena
  • 87a2962: 8335220: C2: Missing check for Opaque4 node in EscapeAnalysis
  • 32ed615: 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop
  • 62d0ee9: 8334421: assert(!oldbox->is_unbalanced()) failed: this should not be called for unbalanced region
  • 98fd657: 8326705: Test CertMsgCheck.java fails to find alert certificate_required
  • d7b9454: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved
  • b5fbdb2: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538
  • ... and 7 more: https://git.openjdk.org/jdk23u/compare/d494c21b9b4589916a1ee1a33b9bcaa5a6479601...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2024
@openjdk openjdk bot closed this Jul 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 8, 2024
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@RealCLanger @weibxiao Pushed as commit bbbfb7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants