Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8339648: ZGC: Division by zero in rule_major_allocation_rate #132

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 4, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339648 needs maintainer approval

Issue

  • JDK-8339648: ZGC: Division by zero in rule_major_allocation_rate (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/132/head:pull/132
$ git checkout pull/132

Update a local copy of the PR:
$ git checkout pull/132
$ git pull https://git.openjdk.org/jdk23u.git pull/132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 132

View PR using the GUI difftool:
$ git pr show -t 132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/132.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339648: ZGC: Division by zero in rule_major_allocation_rate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f5f46a4: 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 80db6e71b092867212147bd369a9fda65dbd4b70 8339648: ZGC: Division by zero in rule_major_allocation_rate Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 4, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 4, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Oct 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 8, 2024

Going to push as commit 8f507a3.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 29cb103: 8340923: The class LogSelection copies uninitialized memory
  • f5f46a4: 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 8, 2024
@openjdk openjdk bot closed this Oct 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2024
@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@MBaesken Pushed as commit 8f507a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MBaesken
Copy link
Member Author

MBaesken commented Oct 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@MBaesken The command integrate can only be used in open pull requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant