8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option

[toddjonker]

Clean backport of patch authored by @tzezula and approved by @dougxc

The patch default-enables useJVMCINativeLibrary when EnableJVMCI is on and libgraal present. While this is a behavior change, it seems unlikely that users would deploy libgraal and not want it used by JVMCI.

This streamlines configuration of our JDK+Graal distro, which in turn allows two failing tests to pass without modification. Ultimately I'm aiming to get this into jdk21 which is our upstream: openjdk/jdk21u-dev#1024

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8340398 needs maintainer approval

Issue

• JDK-8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/136/head:pull/136
$ git checkout pull/136

Update a local copy of the PR:
$ git checkout pull/136
$ git pull https://git.openjdk.org/jdk23u.git pull/136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 136

View PR using the GUI difftool:
$ git pr show -t 136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/136.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back toddjonker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@toddjonker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 83aab07: 8339560: Unaddressed comments during code review of JDK-8337664
• 605f8dd: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
• 2273ff9: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files
• f9c82e4: 8340073: Support "%z" time zone abbreviation format in TZ files
• 35290fa: 8339644: Improve parsing of Day/Month in tzdata rules
• ce81756: 8335530: Java file extension missing in AuthenticatorTest
• d1bd5c0: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• 38910d8: 8341658: RISC-V: Test DateFormatProviderTest.java run timeouted
• c49ef04: 8341806: Gcc version detection failure on Alinux3
• 0be27bf: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• ... and 20 more: https://git.openjdk.org/jdk23u/compare/dc23fd61c5279a6dcadc186883c634da53b7b2cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @toddjonker This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (c1f2edcd)

[toddjonker]

/approval

[openjdk]

@toddjonker usage: /approval [<id>] (request|cancel) [<text>]

[toddjonker]

/approval request This streamlines configuration of our JDK+Graal distro, which in turn allows two failing tests to pass without modification. Ultimately I'm aiming to get this into jdk21 which is our upstream: openjdk/jdk21u-dev#1024

[openjdk]

@toddjonker
8340398: The approval request has been created successfully.

[toddjonker]

/integrate auto

[openjdk]

@toddjonker This pull request will be automatically integrated when it is ready

[openjdk]

/integrate

[openjdk]

@openjdk[bot]
Your change (at version c1f2edc) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit c326ff1.
Since your change was applied there have been 38 commits pushed to the master branch:

• dd1741c: 8337998: CompletionFailure in getEnclosingType attaching type annotations
• babd6cd: 8341235: Improve default instruction frame title in PassFailJFrame
• 126d9c0: 8340799: Add border inside instruction frame in PassFailJFrame
• 167d346: 8340785: Update description of PassFailJFrame and samples
• ff8ac15: 8317116: Provide layouts for multiple test UI in PassFailJFrame
• f01f213: 8340466: Add description for PassFailJFrame constructors
• 4e422da: 8340899: Remove wildcard bound in PositionWindows.positionTestWindows
• 6cd7c13: 8340365: Position the first window of a window list
• 83aab07: 8339560: Unaddressed comments during code review of JDK-8337664
• 605f8dd: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
• ... and 28 more: https://git.openjdk.org/jdk23u/compare/dc23fd61c5279a6dcadc186883c634da53b7b2cc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @toddjonker Pushed as commit c326ff1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.