Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #138

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Oct 7, 2024

Hi all,

This pull request contains a backport of commit 28de44da from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 5 Sep 2024 and was reviewed by Stefan Karlsson, Vladimir Kozlov and Dean Long.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332461 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'

Issue

  • JDK-8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/138/head:pull/138
$ git checkout pull/138

Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.org/jdk23u.git pull/138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 138

View PR using the GUI difftool:
$ git pr show -t 138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/138.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 7, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • fd43645: 8340590: RISC-V: C2: Small improvement to vector gather load and scatter store
  • 8e9f46a: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
  • de15bd5: 8337067: Test runtime/classFileParserBug/Bad_NCDFE_Msg.java won't compile
  • c863673: 8340461: Amend description for logArea
  • 182be02: 8341127: Extra call to MethodHandle::asType from memory segment var handles fails to inline
  • 81e186b: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
  • 8f507a3: 8339648: ZGC: Division by zero in rule_major_allocation_rate
  • 29cb103: 8340923: The class LogSelection copies uninitialized memory
  • f5f46a4: 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 28de44da71871bec7648f01a4df2faee43fa43b6 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' Oct 7, 2024
@openjdk
Copy link

openjdk bot commented Oct 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 7, 2024

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2024

Webrevs

@offamitkumar
Copy link
Member Author

/approval request backport is required as it fixes UBSAN build failure due to missing value in the enum.

@openjdk
Copy link

openjdk bot commented Oct 7, 2024

@offamitkumar
8332461: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 7, 2024
@offamitkumar
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 9, 2024
@openjdk
Copy link

openjdk bot commented Oct 9, 2024

@offamitkumar
Your change (at version 712ed6b) is now ready to be sponsored by a Committer.

@offamitkumar
Copy link
Member Author

@MBaesken would you sponsor this change ?

@MBaesken
Copy link
Member

MBaesken commented Oct 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 9, 2024

Going to push as commit 55d680c.
Since your change was applied there have been 9 commits pushed to the master branch:

  • fd43645: 8340590: RISC-V: C2: Small improvement to vector gather load and scatter store
  • 8e9f46a: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
  • de15bd5: 8337067: Test runtime/classFileParserBug/Bad_NCDFE_Msg.java won't compile
  • c863673: 8340461: Amend description for logArea
  • 182be02: 8341127: Extra call to MethodHandle::asType from memory segment var handles fails to inline
  • 81e186b: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
  • 8f507a3: 8339648: ZGC: Division by zero in rule_major_allocation_rate
  • 29cb103: 8340923: The class LogSelection copies uninitialized memory
  • f5f46a4: 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 9, 2024
@openjdk openjdk bot closed this Oct 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 9, 2024
@openjdk
Copy link

openjdk bot commented Oct 9, 2024

@MBaesken @offamitkumar Pushed as commit 55d680c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants