Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335536: Fix assertion failure in IdealGraphPrinter when append is true #14

Conversation

MaxXSoft
Copy link
Member

@MaxXSoft MaxXSoft commented Jul 5, 2024

Hi all,

This pull request contains a backport of commit 6db4c6a7 from the openjdk/jdk repository.

The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8335536 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8335536: Fix assertion failure in IdealGraphPrinter when append is true (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jdk23u.git pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/14.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

👋 Welcome back qxing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@MaxXSoft This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335536: Fix assertion failure in IdealGraphPrinter when append is true

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bbbfb7f: 8334653: ISO 4217 Amendment 177 Update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6db4c6a772df856fc3099c32a5b2c102a30d360c 8335536: Fix assertion failure in IdealGraphPrinter when append is true Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

⚠️ @MaxXSoft This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2024

Webrevs

@MaxXSoft
Copy link
Member Author

MaxXSoft commented Jul 5, 2024

/approval request Backporting this patch fixes assertion failures when debugging on ideal graph. Applies cleanly and risk is low.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@MaxXSoft
8335536: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 5, 2024
@MaxXSoft
Copy link
Member Author

MaxXSoft commented Jul 9, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@MaxXSoft
Your change (at version 512e3d9) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

Going to push as commit e0dad6d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • bbbfb7f: 8334653: ISO 4217 Amendment 177 Update

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2024
@openjdk openjdk bot closed this Jul 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@RealCLanger @MaxXSoft Pushed as commit e0dad6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants