Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #147

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 10, 2024

Hi all,

This pull request contains a backport of commit 9d621d39 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 10 Oct 2024 and was reviewed by Severin Gehwolf and Brian Burkhalter.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338884 needs maintainer approval

Issue

  • JDK-8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/147/head:pull/147
$ git checkout pull/147

Update a local copy of the PR:
$ git checkout pull/147
$ git pull https://git.openjdk.org/jdk23u.git pull/147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 147

View PR using the GUI difftool:
$ git pr show -t 147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/147.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9d621d3914b39cfdcda97274a7af5ca0fe062d35 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug, the change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@sendaoYan
8338884: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 10, 2024
@chhagedorn
Copy link
Member

@sendaoYan The mainline patch caused build failures on linux-x64 in tier1 in our CI. We backed the change out (see openjdk/jdk#21441).

@sendaoYan
Copy link
Member Author

@sendaoYan The mainline patch caused build failures on linux-x64 in tier1 in our CI. We backed the change out (see openjdk/jdk#21441).

Okey.

@sendaoYan sendaoYan closed this Oct 10, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented Oct 12, 2024

/approval cancel

@openjdk
Copy link

openjdk bot commented Oct 12, 2024

@sendaoYan
8338884: The request has already been handled by a maintainer and can no longer be canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants