-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature #148
Conversation
👋 Welcome back rgangadhar! A progress list of the required criteria for merging this PR into |
@rgangadhar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval JDK-8333317 request Backporting to JDK23u release |
@rgangadhar |
Hi @coffeys please review and sponsor |
/integrate |
@rgangadhar |
/sponsor |
Going to push as commit 5de6c65. |
@coffeys @rgangadhar Pushed as commit 5de6c65. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/148/head:pull/148
$ git checkout pull/148
Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.org/jdk23u.git pull/148/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 148
View PR using the GUI difftool:
$ git pr show -t 148
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/148.diff
Webrev
Link to Webrev Comment