Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp #150

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Oct 10, 2024

Hi all,

This pull request contains a backport of commit 6f4ddc2f from the openjdk/jdk repository.

The commit being backported was authored by Christian Hagedorn on 28 Jun 2024 and was reviewed by Tobias Hartmann and Vladimir Kozlov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335142 needs maintainer approval

Issue

  • JDK-8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/150/head:pull/150
$ git checkout pull/150

Update a local copy of the PR:
$ git checkout pull/150
$ git pull https://git.openjdk.org/jdk23u.git pull/150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 150

View PR using the GUI difftool:
$ git pr show -t 150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/150.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 55ef494: 8333306: gc/arguments/TestParallelGCErgo.java fails when largepage are enabled
  • 5de6c65: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6f4ddc2f6bf0dd9a626a76d0f5e56a54c6cf6b65 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Oct 10, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 12, 2024
@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

Going to push as commit 5460227.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 8915084: 8323688: C2: Fix UB of jlong overflow in PhaseIdealLoop::is_counted_loop()
  • c2b5759: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
  • 55ef494: 8333306: gc/arguments/TestParallelGCErgo.java fails when largepage are enabled
  • 5de6c65: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2024
@openjdk openjdk bot closed this Oct 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@TobiHartmann Pushed as commit 5460227.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant