Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

8335530: Java file extension missing in AuthenticatorTest #153

Closed
wants to merge 1 commit into from

Conversation

johnyjose30
Copy link
Contributor

@johnyjose30 johnyjose30 commented Oct 10, 2024

clean backport of https://git.openjdk.org/jdk/commit/a537e87d2d2c6bff63f63bb436e3e919740221ce


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335530 needs maintainer approval

Issue

  • JDK-8335530: Java file extension missing in AuthenticatorTest (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/153/head:pull/153
$ git checkout pull/153

Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jdk23u.git pull/153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 153

View PR using the GUI difftool:
$ git pr show -t 153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/153.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2024

👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335530: Java file extension missing in AuthenticatorTest

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • d1bd5c0: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
  • 38910d8: 8341658: RISC-V: Test DateFormatProviderTest.java run timeouted
  • c49ef04: 8341806: Gcc version detection failure on Alinux3
  • 0be27bf: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
  • 9fdcee9: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
  • ff109ac: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
  • 6250c5d: 8335709: C2: assert(!loop->is_member(get_loop(useblock))) failed: must be outside loop
  • 5460227: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp
  • 8915084: 8323688: C2: Fix UB of jlong overflow in PhaseIdealLoop::is_counted_loop()
  • c2b5759: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
  • ... and 2 more: https://git.openjdk.org/jdk23u/compare/e2f4c7a110d6b1edadd0c0a8fdccc9d1d924735a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a537e87d2d2c6bff63f63bb436e3e919740221ce 8335530: Java file extension missing in AuthenticatorTest Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

⚠️ @johnyjose30 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 10, 2024
@johnyjose30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@johnyjose30
Your change (at version bf78e8a) is now ready to be sponsored by a Committer.

@raviniitw2012
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

Going to push as commit ce81756.
Since your change was applied there have been 12 commits pushed to the master branch:

  • d1bd5c0: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
  • 38910d8: 8341658: RISC-V: Test DateFormatProviderTest.java run timeouted
  • c49ef04: 8341806: Gcc version detection failure on Alinux3
  • 0be27bf: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
  • 9fdcee9: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
  • ff109ac: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
  • 6250c5d: 8335709: C2: assert(!loop->is_member(get_loop(useblock))) failed: must be outside loop
  • 5460227: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp
  • 8915084: 8323688: C2: Fix UB of jlong overflow in PhaseIdealLoop::is_counted_loop()
  • c2b5759: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
  • ... and 2 more: https://git.openjdk.org/jdk23u/compare/e2f4c7a110d6b1edadd0c0a8fdccc9d1d924735a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2024
@openjdk openjdk bot closed this Oct 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@raviniitw2012 @johnyjose30 Pushed as commit ce81756.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants