8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter

[zifeihan]

Hi, The same issue also exists in the jdk23u. I would like to backport 8341146 to jdk23u. This is a risc-v specific change. Backport is clean, risk is low.

Testing on SOPHON SG2042 (release)

• JCstress
• Run tier1 tests
• ~5% improvement on SPECJbb2005 score (-Xint -XX:+UseParallelGC)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8341146 needs maintainer approval

Issue

• JDK-8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.org/jdk23u.git pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/154.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 2273ff9: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files
• f9c82e4: 8340073: Support "%z" time zone abbreviation format in TZ files
• 35290fa: 8339644: Improve parsing of Day/Month in tzdata rules
• ce81756: 8335530: Java file extension missing in AuthenticatorTest
• d1bd5c0: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• 38910d8: 8341658: RISC-V: Test DateFormatProviderTest.java run timeouted
• c49ef04: 8341806: Gcc version detection failure on Alinux3
• 0be27bf: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• 9fdcee9: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
• ff109ac: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
• ... and 5 more: https://git.openjdk.org/jdk23u/compare/5de6c65a55cd34878065a8f06315cfd1a5653498...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (0e5c5e9f)

[zifeihan]

/integrate

[openjdk]

@zifeihan
Your change (at version 0e5c5e9) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 605f8dd.
Since your change was applied there have been 15 commits pushed to the master branch:

• 2273ff9: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files
• f9c82e4: 8340073: Support "%z" time zone abbreviation format in TZ files
• 35290fa: 8339644: Improve parsing of Day/Month in tzdata rules
• ce81756: 8335530: Java file extension missing in AuthenticatorTest
• d1bd5c0: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• 38910d8: 8341658: RISC-V: Test DateFormatProviderTest.java run timeouted
• c49ef04: 8341806: Gcc version detection failure on Alinux3
• 0be27bf: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• 9fdcee9: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
• ff109ac: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
• ... and 5 more: https://git.openjdk.org/jdk23u/compare/5de6c65a55cd34878065a8f06315cfd1a5653498...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit 605f8dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.