8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code

[sendaoYan]

Hi all,

This pull request contains a backport of commit d636e0d3 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 9 Oct 2024 and was reviewed by Andrew Haley, Johan Sjölen and Julian Waters.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8341688 needs maintainer approval

Issue

• JDK-8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/155/head:pull/155
$ git checkout pull/155

Update a local copy of the PR:
$ git checkout pull/155
$ git pull https://git.openjdk.org/jdk23u.git pull/155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 155

View PR using the GUI difftool:
$ git pr show -t 155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/155.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 55ef494: 8333306: gc/arguments/TestParallelGCErgo.java fails when largepage are enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[sendaoYan]

/approval request Clean backport to generate comments in -XX:+PrintInterpreter to link to source code for RISC-V, this will be usefull to debug the inperpreter. Only change the PrintInterpreter output, risk is low.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@sendaoYan
8341688: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (27247731)

[sendaoYan]

Thanks for the approved.
/integrate

[openjdk]

@sendaoYan
Your change (at version 2724773) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 0be27bf.
Since your change was applied there have been 7 commits pushed to the master branch:

• 9fdcee9: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
• ff109ac: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
• 6250c5d: 8335709: C2: assert(!loop->is_member(get_loop(useblock))) failed: must be outside loop
• 5460227: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp
• 8915084: 8323688: C2: Fix UB of jlong overflow in PhaseIdealLoop::is_counted_loop()
• c2b5759: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
• 55ef494: 8333306: gc/arguments/TestParallelGCErgo.java fails when largepage are enabled

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @sendaoYan Pushed as commit 0be27bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.