Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram #16

Closed
wants to merge 1 commit into from

Conversation

Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Jul 6, 2024

Straight backport
https://mach5.us.oracle.com/mdash/jobs/sshivang-adhoc-20240705-0937-13356821


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8299813 needs maintainer approval

Issue

  • JDK-8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jdk23u.git pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/16.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2024

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 6, 2024

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 5cfaec2: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
  • 13e53b8: Merge
  • 5b9ecb1: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.
  • 70ad622: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range
  • ca37a48: 8334757: AssertionError: Missing type variable in where clause
  • ae10055: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
  • 4e52320: 8334433: jshell.exe runs an executable test.exe on startup
  • 2f60d36: 8335475: ClassBuilder incorrectly calculates max_locals in some cases
  • b415b98: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
  • 90d5b5b: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
  • ... and 10 more: https://git.openjdk.org/jdk23u/compare/2723ffa8ed19c70881d86a9f0cf188bc6d886a8c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 49eb00da8dc66cff3ca430f06ab21357ee6180ef 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram Jul 6, 2024
@openjdk
Copy link

openjdk bot commented Jul 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 6, 2024

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2024

Webrevs

@Shivangi-aa
Copy link
Author

@coffeys Can you please review it.

@Shivangi-aa
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@Shivangi-aa usage: /approval [<id>] (request|cancel) [<text>]

@Shivangi-aa
Copy link
Author

/approval JDK-8299813 request Backporting bug to 23 as failing in lower releases CI

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@Shivangi-aa
JDK-8299813: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 9, 2024
@Shivangi-aa
Copy link
Author

/integrate auto

@openjdk openjdk bot added the auto label Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@Shivangi-aa This pull request will be automatically integrated when it is ready

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 11, 2024
@openjdk
Copy link

openjdk bot commented Jul 11, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 11, 2024
@openjdk
Copy link

openjdk bot commented Jul 11, 2024

@openjdk[bot]
Your change (at version d911c2c) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Jul 11, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 11, 2024

Going to push as commit 4ca2e48.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 5cfaec2: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
  • 13e53b8: Merge
  • 5b9ecb1: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.
  • 70ad622: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range
  • ca37a48: 8334757: AssertionError: Missing type variable in where clause
  • ae10055: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
  • 4e52320: 8334433: jshell.exe runs an executable test.exe on startup
  • 2f60d36: 8335475: ClassBuilder incorrectly calculates max_locals in some cases
  • b415b98: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
  • 90d5b5b: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
  • ... and 10 more: https://git.openjdk.org/jdk23u/compare/2723ffa8ed19c70881d86a9f0cf188bc6d886a8c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2024
@openjdk openjdk bot closed this Jul 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2024
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jul 11, 2024
@openjdk
Copy link

openjdk bot commented Jul 11, 2024

@coffeys @Shivangi-aa Pushed as commit 4ca2e48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants