Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options #160

Closed
wants to merge 1 commit into from

Conversation

prkoppul
Copy link

@prkoppul prkoppul commented Oct 14, 2024

clean backport


Progress

  • JDK-8331391 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jdk23u.git pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/160.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back pkoppula! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@prkoppul This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

  • cf75776: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop
  • caa8f35: 8341997: Tests create files in src tree instead of scratch dir
  • 56fcf0b: 8342014: RISC-V: ZStoreBarrierStubC2 clobbers rflags
  • 46abc06: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java
  • a858c27: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java
  • d470f69: 8337886: java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight color difference
  • 6d9d35b: 8341024: [test] build/AbsPathsInImage.java fails with OOM when using ubsan-enabled binaries
  • 43e1328: Merge
  • a3fde48: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 047c522: 8341057: Add 2 SSL.com TLS roots
  • ... and 41 more: https://git.openjdk.org/jdk23u/compare/54602276bc95ac631d540bf14657f38b8ffab196...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c9bee173d61f4accfc4adc280ab5d21600191756 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

⚠️ @prkoppul This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2024
@prkoppul
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@prkoppul usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Oct 14, 2024

Webrevs

@prkoppul
Copy link
Author

/approval 8331391 request

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@prkoppul
8331391: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 15, 2024
@prkoppul
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 17, 2024
@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@prkoppul
Your change (at version 1cc8f3a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

@prkoppul, please enable pre-integration testing on this repo.

@coffeys
Copy link
Contributor

coffeys commented Oct 18, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

Going to push as commit 9ed9510.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 858118e: 8335267: [XWayland] move screencast tokens from .awt to .java folder
  • 6317a5a: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList
  • 9b56b71: 8337320: Update ProblemList.txt with tests known to fail on XWayland
  • f3be592: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf
  • daa67f4: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
  • 16f279c: 8336914: Shenandoah: Missing verification steps after JDK-8255765
  • f83e643: 8337622: IllegalArgumentException in java.lang.reflect.Field.get
  • cd61f97: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result
  • 64200b3: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage
  • b428316: 8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • ... and 51 more: https://git.openjdk.org/jdk23u/compare/54602276bc95ac631d540bf14657f38b8ffab196...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2024
@openjdk openjdk bot closed this Oct 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@coffeys @prkoppul Pushed as commit 9ed9510.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants