-
Notifications
You must be signed in to change notification settings - Fork 61
8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java #164
Conversation
|
👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into |
|
@Shivangi-aa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval JDK-8338759 request Good to backport .Adding diagnostics |
|
@Shivangi-aa |
|
/integrate auto |
|
@Shivangi-aa This pull request will be automatically integrated when it is ready |
|
/integrate |
|
/sponsor |
|
Going to push as commit a858c27.
Your commit was automatically rebased without conflicts. |
|
@coffeys @Shivangi-aa Pushed as commit a858c27. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Straight Backport. Good to backport. Test is passing on all platforms.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/164/head:pull/164$ git checkout pull/164Update a local copy of the PR:
$ git checkout pull/164$ git pull https://git.openjdk.org/jdk23u.git pull/164/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 164View PR using the GUI difftool:
$ git pr show -t 164Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/164.diff
Webrev
Link to Webrev Comment