Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Oct 14, 2024

This pull request contains a backport of commit 3762ec39 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 26 Sep 2024 and was reviewed by Phil Race and Harshitha Onkar.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340466 needs maintainer approval

Issue

  • JDK-8340466: Add description for PassFailJFrame constructors (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/171/head:pull/171
$ git checkout pull/171

Update a local copy of the PR:
$ git checkout pull/171
$ git pull https://git.openjdk.org/jdk23u.git pull/171/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 171

View PR using the GUI difftool:
$ git pr show -t 171

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/171.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340466: Add description for PassFailJFrame constructors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3762ec3978bfe9910929ab22aaf238e9f4c84630 8340466: Add description for PassFailJFrame constructors Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2024

Webrevs

@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

Going to push as commit f01f213.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 4e422da: 8340899: Remove wildcard bound in PositionWindows.positionTestWindows
  • 6cd7c13: 8340365: Position the first window of a window list

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 15, 2024
@openjdk openjdk bot closed this Oct 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 15, 2024
@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@aivanov-jdk Pushed as commit f01f213.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant