Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

8334418: Update IANA Language Subtag Registry to Version 2024-06-14 #18

Conversation

weibxiao
Copy link

@weibxiao weibxiao commented Jul 10, 2024

Update IANA Language Subtag Registry to Version 2024-06-14


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334418 needs maintainer approval

Issue

  • JDK-8334418: Update IANA Language Subtag Registry to Version 2024-06-14 (Bug - P3 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/jdk23u.git pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/18.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

👋 Welcome back wxiao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 861aefcafacdc21459ef966307f52568e327fd49 8334418: Update IANA Language Subtag Registry to Version 2024-06-14 Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

⚠️ @weibxiao This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 10, 2024
@weibxiao
Copy link
Author

/approval request

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@weibxiao
8334418: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2024

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Jul 12, 2024

@weibxiao A backport is in progress for JDK 23, openjdk/jdk#20125

Please close this jdk23u PR. A fix for the JDK 23 release family is backported to either jdk:jdk23 or jdk23u, never both.

@openjdk openjdk bot removed the approval label Jul 12, 2024
@weibxiao
Copy link
Author

closed it. It is no need any more. See the commit at openjdk/jdk#20125

@weibxiao weibxiao closed this Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants