8340313: Crash due to invalid oop in nmethod after C1 patching

[TobiHartmann]

Hi all,

This pull request contains a backport of commit 58d39c31 from the openjdk/jdk repository.

The change did not apply cleanly due to differences in src/hotspot/cpu/riscv/nativeInst_riscv.cpp.

The commit being backported was authored by Tobias Hartmann on 17 Oct 2024 and was reviewed by Thomas Schatzl, Vladimir Kozlov and Dean Long.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8340313 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8340313: Crash due to invalid oop in nmethod after C1 patching (Bug - P2 - Approved)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/189/head:pull/189
$ git checkout pull/189

Update a local copy of the PR:
$ git checkout pull/189
$ git pull https://git.openjdk.org/jdk23u.git pull/189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 189

View PR using the GUI difftool:
$ git pr show -t 189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/189.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340313: Crash due to invalid oop in nmethod after C1 patching

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 73b2341: 8339637: (tz) Update Timezone Data to 2024b
• dc5298e: 8342145: File libCreationTimeHelper.c compile fails on Alpine
• 14aedb5: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep
• 9ed9510: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
• 858118e: 8335267: [XWayland] move screencast tokens from .awt to .java folder
• 6317a5a: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList
• 9b56b71: 8337320: Update ProblemList.txt with tests known to fail on XWayland
• f3be592: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf
• daa67f4: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
• 16f279c: 8336914: Shenandoah: Missing verification steps after JDK-8255765
• ... and 6 more: https://git.openjdk.org/jdk23u/compare/56fcf0b1d48069dcc16398349f23d8c258894b99...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (f03fe637)

[chhagedorn]

Looks good!

[TobiHartmann]

Thanks Christian!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit c644570.
Since your change was applied there have been 16 commits pushed to the master branch:

• 73b2341: 8339637: (tz) Update Timezone Data to 2024b
• dc5298e: 8342145: File libCreationTimeHelper.c compile fails on Alpine
• 14aedb5: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep
• 9ed9510: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
• 858118e: 8335267: [XWayland] move screencast tokens from .awt to .java folder
• 6317a5a: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList
• 9b56b71: 8337320: Update ProblemList.txt with tests known to fail on XWayland
• f3be592: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf
• daa67f4: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
• 16f279c: 8336914: Shenandoah: Missing verification steps after JDK-8255765
• ... and 6 more: https://git.openjdk.org/jdk23u/compare/56fcf0b1d48069dcc16398349f23d8c258894b99...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit c644570.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.