Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields #190

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Oct 17, 2024

Hi all,

This pull request contains a backport of commit 13dce296 from the openjdk/jdk repository.

The commit being backported was authored by Richard Reingruber on 24 Jun 2024 and was reviewed by Matthias Baesken and Martin Doerr.

The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, Renaissance Suite, and SAP specific tests.
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.

Risk is low. The change affects only PPC64 and the field that is changed is only read in the JVMTI implementation. Also the change includes a regression test.

Thanks, Richard.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334560 needs maintainer approval

Issue

  • JDK-8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/190/head:pull/190
$ git checkout pull/190

Update a local copy of the PR:
$ git checkout pull/190
$ git pull https://git.openjdk.org/jdk23u.git pull/190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 190

View PR using the GUI difftool:
$ git pr show -t 190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/190.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2024

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • e1fab4b: 8333824: Unused ClassValue in VarHandles
  • e1688ad: 8342612: Increase memory usage of compiler/c2/TestScalarReplacementMaxLiveNodes.java
  • ce19269: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java
  • f949f3f: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()
  • c644570: 8340313: Crash due to invalid oop in nmethod after C1 patching
  • 73b2341: 8339637: (tz) Update Timezone Data to 2024b
  • dc5298e: 8342145: File libCreationTimeHelper.c compile fails on Alpine
  • 14aedb5: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep
  • 9ed9510: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • 858118e: 8335267: [XWayland] move screencast tokens from .awt to .java folder
  • ... and 11 more: https://git.openjdk.org/jdk23u/compare/56fcf0b1d48069dcc16398349f23d8c258894b99...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 13dce296fc3924b269757ce1279c57afe18faeeb 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields Oct 17, 2024
@openjdk
Copy link

openjdk bot commented Oct 17, 2024

This backport pull request has now been updated with issue from the original commit.

@reinrich reinrich marked this pull request as ready for review October 22, 2024 12:39
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 22, 2024
@reinrich
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

Going to push as commit 26e077b.
Since your change was applied there have been 22 commits pushed to the master branch:

  • eacb0fb: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64
  • e1fab4b: 8333824: Unused ClassValue in VarHandles
  • e1688ad: 8342612: Increase memory usage of compiler/c2/TestScalarReplacementMaxLiveNodes.java
  • ce19269: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java
  • f949f3f: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()
  • c644570: 8340313: Crash due to invalid oop in nmethod after C1 patching
  • 73b2341: 8339637: (tz) Update Timezone Data to 2024b
  • dc5298e: 8342145: File libCreationTimeHelper.c compile fails on Alpine
  • 14aedb5: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep
  • 9ed9510: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • ... and 12 more: https://git.openjdk.org/jdk23u/compare/56fcf0b1d48069dcc16398349f23d8c258894b99...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2024
@openjdk openjdk bot closed this Oct 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2024
@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@reinrich Pushed as commit 26e077b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant