8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()

[nelanbu]

Hi all,

This pull request contains a backport of commit 90c944fe from the openjdk/jdk repository.

The change applied cleanly.

The commit being backported was authored by Roland Westrelin on 2 Oct 2024 and was reviewed by Vladimir Ivanov and Quan Anh Mai.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8340824 needs maintainer approval

Issue

• JDK-8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/197/head:pull/197
$ git checkout pull/197

Update a local copy of the PR:
$ git checkout pull/197
$ git pull https://git.openjdk.org/jdk23u.git pull/197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 197

View PR using the GUI difftool:
$ git pr show -t 197

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/197.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nelanbu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nelanbu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• c644570: 8340313: Crash due to invalid oop in nmethod after C1 patching
• 73b2341: 8339637: (tz) Update Timezone Data to 2024b
• dc5298e: 8342145: File libCreationTimeHelper.c compile fails on Alpine

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @nelanbu This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (e7bfbdee)

[nelanbu]

/approval request Clean backport to fix memory reclamation issue for TypeInterfaces object by hashcons().

[openjdk]

@nelanbu
8340824: The approval request has been created successfully.

[nelanbu]

/integrate

[openjdk]

@nelanbu
Your change (at version e7bfbde) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit f949f3f.
Since your change was applied there have been 3 commits pushed to the master branch:

• c644570: 8340313: Crash due to invalid oop in nmethod after C1 patching
• 73b2341: 8339637: (tz) Update Timezone Data to 2024b
• dc5298e: 8342145: File libCreationTimeHelper.c compile fails on Alpine

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @nelanbu Pushed as commit f949f3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.