Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Oct 20, 2024

Straight Backport. Cleanups and JUnit conversion. Good To backport to lower releases.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339154 needs maintainer approval

Issue

  • JDK-8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java (Enhancement - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.org/jdk23u.git pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/199.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2024

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2024

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • f949f3f: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()
  • c644570: 8340313: Crash due to invalid oop in nmethod after C1 patching
  • 73b2341: 8339637: (tz) Update Timezone Data to 2024b

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f927c1210ee0675bb1196572177ffb505826d57a 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java Oct 20, 2024
@openjdk
Copy link

openjdk bot commented Oct 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2024

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2024

Webrevs

@Shivangi-aa
Copy link
Author

/approval JDK-8339154 request Cleanups and JUnit conversion. Good To backport to lower releases. All test Passed

@openjdk
Copy link

openjdk bot commented Oct 20, 2024

@Shivangi-aa
JDK-8339154: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 20, 2024
@Shivangi-aa
Copy link
Author

/integrate auto

@openjdk openjdk bot added the auto label Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@Shivangi-aa This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@openjdk[bot]
Your change (at version d2d33f3) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Oct 22, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

Going to push as commit ce19269.
Since your change was applied there have been 3 commits pushed to the master branch:

  • f949f3f: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()
  • c644570: 8340313: Crash due to invalid oop in nmethod after C1 patching
  • 73b2341: 8339637: (tz) Update Timezone Data to 2024b

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 22, 2024
@openjdk openjdk bot closed this Oct 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@coffeys @Shivangi-aa Pushed as commit ce19269.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants