Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV #2

Closed
wants to merge 1 commit into from
Closed

8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV #2

wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Jun 12, 2024 •
edited by openjdk bot
Loading

Hi, The same issue also exists in the JDK23U: I can reproduce it locally and use this clean patch can fix that issue, So I would like to backport this to JDK23U. This is a risc-v specific change. Backport is clean, risk is low.

Testing

  • test/jdk/jdk/incubator/vector on Banana Pi BPI-F3 board (with RVV1.0)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333652 needs maintainer approval

Issue

  • JDK-8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.org/jdk23u.git pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/2.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024 •
edited
Loading

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ce5727df4436425b24b89f24c6e6b708575ec7c6 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Jun 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 27, 2024
@zifeihan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 29, 2024
@openjdk
Copy link

openjdk bot commented Jun 29, 2024

@zifeihan
Your change (at version caee232) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 29, 2024

Going to push as commit d494c21.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 29, 2024
@openjdk openjdk bot closed this Jun 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 29, 2024
@openjdk
Copy link

openjdk bot commented Jun 29, 2024

@RealFYang @zifeihan Pushed as commit d494c21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

battleblow referenced this pull request in battleblow/jdk23u Aug 11, 2024
@battleblow
Working extended file attributes for BSD (#2)
db09166 
* Add code that handles the BSD extended file attribute semantics.
  This allows them to work correctly on FreeBSD.
* Make the Linux semantics the default to avoid changing the Linux
  code.  Ideally we'd be explicit everywhere instead, but this likely
  makes merges simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport clean integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zifeihan @RealFYang