Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message #20

Closed
wants to merge 1 commit into from

Conversation

Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Jul 14, 2024

Straight Backport

https://mach5.us.oracle.com/mdash/jobs/sshivang-adhoc-20240714-0825-13799277


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8269657 needs maintainer approval

Issue

  • JDK-8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/20/head:pull/20
$ git checkout pull/20

Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.org/jdk23u.git pull/20/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20

View PR using the GUI difftool:
$ git pr show -t 20

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/20.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2024

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c798316bc4cb33fd902f926030d8a0b6870d661a 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message Jul 14, 2024
@openjdk
Copy link

openjdk bot commented Jul 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 14, 2024

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2024
@Shivangi-aa
Copy link
Author

/approval JDK-8269657 request Backporting bug to 23 as failing in lower releases CI

@openjdk
Copy link

openjdk bot commented Jul 14, 2024

@Shivangi-aa
JDK-8269657: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 14, 2024
@Shivangi-aa
Copy link
Author

/integrate auto

@openjdk openjdk bot added the auto label Jul 14, 2024
@openjdk
Copy link

openjdk bot commented Jul 14, 2024

@Shivangi-aa This pull request will be automatically integrated when it is ready

@mlbridge
Copy link

mlbridge bot commented Jul 14, 2024

Webrevs

@sendaoYan
Copy link
Member

Does this duplicated to openjdk/jdk#19936

@Shivangi-aa
Copy link
Author

Looks Like duplicate openjdk/jdk#19936

@kevinrushforth
Copy link
Member

@Shivangi-aa In that case, please close this jdk23u PR. A fix for the JDK 23 release family is backported to either jdk:jdk23 or jdk23u, never both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval auto backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants