-
Notifications
You must be signed in to change notification settings - Fork 62
8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust #205
Conversation
|
👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into |
|
@Shivangi-aa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval JDK-8324672 request Good to Backport. Test only change. All test passes. |
|
@Shivangi-aa |
|
/integrate auto |
|
@Shivangi-aa This pull request will be automatically integrated when it is ready |
|
/integrate |
|
/sponsor |
|
Going to push as commit a690507.
Your commit was automatically rebased without conflicts. |
|
@robm-openjdk @Shivangi-aa Pushed as commit a690507. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Straight Backport. Test passed.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/205/head:pull/205$ git checkout pull/205Update a local copy of the PR:
$ git checkout pull/205$ git pull https://git.openjdk.org/jdk23u.git pull/205/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 205View PR using the GUI difftool:
$ git pr show -t 205Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/205.diff
Webrev
Link to Webrev Comment