Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java #206

Closed

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Oct 24, 2024

Hi all,

This pull request contains a backport of commit 66286b25 from the openjdk/jdk repository.

The commit being backported was authored by Tobias Hartmann on 7 Aug 2024 and was reviewed by Christian Hagedorn.

The reason for the backport is intermittent failures seen on the jdk23u CI pipeline.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337968 needs maintainer approval

Issue

  • JDK-8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/206/head:pull/206
$ git checkout pull/206

Update a local copy of the PR:
$ git checkout pull/206
$ git pull https://git.openjdk.org/jdk23u.git pull/206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 206

View PR using the GUI difftool:
$ git pr show -t 206

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/206.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b9e89a8: 8341966: Broken annotated module may lead to an exception in javac
  • 8985dab: 8338751: ConfigureNotify behavior has changed in KWin 6.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 66286b25a183de2ffd0689da9c2bd1978b881aa7 8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java Oct 24, 2024
@openjdk
Copy link

openjdk bot commented Oct 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

⚠️ @dougxc This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2024

Webrevs

@dougxc
Copy link
Member Author

dougxc commented Oct 24, 2024

/approval request

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@dougxc
8337968: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 24, 2024
@dougxc
Copy link
Member Author

dougxc commented Oct 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2024

Going to push as commit f7b4584.
Since your change was applied there have been 3 commits pushed to the master branch:

  • e56655f: 8342701: [PPC64] TestOSRLotsOfLocals.java crashes
  • b9e89a8: 8341966: Broken annotated module may lead to an exception in javac
  • 8985dab: 8338751: ConfigureNotify behavior has changed in KWin 6.2

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2024
@openjdk openjdk bot closed this Oct 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2024
@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@dougxc Pushed as commit f7b4584.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant