8342962: [s390x] TestOSRLotsOfLocals.java crashes

[offamitkumar]

Hi all,

This pull request contains a backport of commit 54327bc4 from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 29 Oct 2024 and was reviewed by Lutz Schmidt and Martin Doerr.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8342962 needs maintainer approval

Issue

• JDK-8342962: [s390x] TestOSRLotsOfLocals.java crashes (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/209/head:pull/209
$ git checkout pull/209

Update a local copy of the PR:
$ git checkout pull/209
$ git pull https://git.openjdk.org/jdk23u.git pull/209/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 209

View PR using the GUI difftool:
$ git pr show -t 209

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/209.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342962: [s390x] TestOSRLotsOfLocals.java crashes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 7f189a5: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set
• 52e373c: 8337753: Target class of upcall stub may be unloaded
• 7f49da1: 8337851: Some tests have name which confuse jtreg
• e534863: 8336942: Improve test coverage for class loading elements with annotations of different retentions
• e075b95: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (7568e50f)

[offamitkumar]

/approval request JDK23 is affected by this bug. current fix only touches one s390 specific file and applies cleanly. tier1 test run shows no regression.

[openjdk]

@offamitkumar
8342962: The approval request has been created successfully.

[offamitkumar]

/integrate

[openjdk]

@offamitkumar
Your change (at version 7568e50) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 69d97e0.
Since your change was applied there have been 6 commits pushed to the master branch:

• 6458800: 8334442: Temporarily disable return type assertion to reduce noise in testing
• 7f189a5: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set
• 52e373c: 8337753: Target class of upcall stub may be unloaded
• 7f49da1: 8337851: Some tests have name which confuse jtreg
• e534863: 8336942: Improve test coverage for class loading elements with annotations of different retentions
• e075b95: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @offamitkumar Pushed as commit 69d97e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.