Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion #21

Closed
wants to merge 1 commit into from

Conversation

Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Jul 14, 2024

Straight Backport
https://mach5.us.oracle.com/mdash/jobs/sshivang-adhoc-20240714-1035-13800016


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336301 needs maintainer approval

Issue

  • JDK-8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/21/head:pull/21
$ git checkout pull/21

Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.org/jdk23u.git pull/21/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21

View PR using the GUI difftool:
$ git pr show -t 21

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/21.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2024

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 14, 2024

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • e9d86d8: 8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer
  • 821a3aa: 8333887: ubsan: unsafe.cpp:247:13: runtime error: store to null pointer of type 'volatile int'
  • 8883b15: 8325525: Create jtreg test case for JDK-8325203
  • e4d80b1: 8334123: log the opening of Type 1 fonts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ae9f318fc35eeab497e546ebab9faed6ec774ec5 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Jul 14, 2024
@openjdk
Copy link

openjdk bot commented Jul 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 14, 2024

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2024
@Shivangi-aa
Copy link
Author

/approval JDK-8336301 request Backporting bug to 23 required in lower releases

@openjdk
Copy link

openjdk bot commented Jul 14, 2024

@Shivangi-aa
JDK-8336301: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 16, 2024
@Shivangi-aa
Copy link
Author

/integrate auto

@openjdk openjdk bot added the auto label Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@Shivangi-aa This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Jul 17, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@openjdk[bot]
Your change (at version 7dfa83e) is now ready to be sponsored by a Committer.

@Shivangi-aa
Copy link
Author

@coffeys Can you please sponsor this.

@coffeys
Copy link
Contributor

coffeys commented Jul 17, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 17, 2024

Going to push as commit c5f294b.
Since your change was applied there have been 4 commits pushed to the master branch:

  • e9d86d8: 8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer
  • 821a3aa: 8333887: ubsan: unsafe.cpp:247:13: runtime error: store to null pointer of type 'volatile int'
  • 8883b15: 8325525: Create jtreg test case for JDK-8325203
  • e4d80b1: 8334123: log the opening of Type 1 fonts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2024
@openjdk openjdk bot closed this Jul 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@coffeys @Shivangi-aa Pushed as commit c5f294b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants