-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8333887: ubsan: unsafe.cpp:247:13: runtime error: store to null pointer of type 'volatile int' #22
Conversation
👋 Welcome back luwang1103! A progress list of the required criteria for merging this PR into |
@luwang1103 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request The code applies cleanly. Low risk: It is a corner case which is not triggered by the current code. In order to avoid bugs in the future, it is good to backport it. |
@luwang1103 |
/integrate |
@luwang1103 |
@RealCLanger Can you please sponsor the changes? thanks |
I'll sponsor, as I think this is safe. Going forward, please enable GHA and pass them, see the "Pre-submit test status" in the box above. |
/sponsor |
@shipilev @luwang1103 Pushed as commit 821a3aa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
hi ,
This pull request contains a backport of commit 0d3a3771 from the master repository.
The commit being backported was authored by Matthias Baesken on 13 Jun 2024.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/22/head:pull/22
$ git checkout pull/22
Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/jdk23u.git pull/22/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22
View PR using the GUI difftool:
$ git pr show -t 22
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/22.diff
Webrev
Link to Webrev Comment