8336012: Fix usages of jtreg-reserved properties

[offamitkumar]

Hi all,

This pull request contains a backport of commit e6c5aa7a from the openjdk/jdk repository.

test/jdk/java/lang/invoke/PrivateInvokeTest.java is failing on s390x JDK23 - CI consistently. error:

STDERR:
STARTED    test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst'
java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:588)
	at java.base/java.lang.Integer.parseInt(Integer.java:685)
	at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485)
FAILED     test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' [60ms]
STARTED    test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect'
java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:588)
	at java.base/java.lang.Integer.parseInt(Integer.java:685)
	at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485)
FAILED     test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' [4ms]
JavaTest Message: JUnit Platform Failure(s): 2

[ JUnit Containers: found 4, started 4, succeeded 4, failed 0, aborted 0, skipped 0]
[ JUnit Tests: found 2, started 2, succeeded 0, failed 2, aborted 0, skipped 0]

java.lang.Exception: JUnit test failure
	at com.sun.javatest.regtest.agent.JUnitRunner.runWithJUnitPlatform(JUnitRunner.java:155)
	at com.sun.javatest.regtest.agent.JUnitRunner.main(JUnitRunner.java:99)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
	at java.base/java.lang.Thread.run(Thread.java:1575)

JavaTest Message: Test threw exception: java.lang.Exception
JavaTest Message: shutting down test

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8336012 needs maintainer approval

Issue

• JDK-8336012: Fix usages of jtreg-reserved properties (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/222/head:pull/222
$ git checkout pull/222

Update a local copy of the PR:
$ git checkout pull/222
$ git pull https://git.openjdk.org/jdk23u.git pull/222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 222

View PR using the GUI difftool:
$ git pr show -t 222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/222.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336012: Fix usages of jtreg-reserved properties

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• d620426: 8340586: JdkJfrEvent::get_all_klasses stores non-strong oops in JNI handles
• 37c05c0: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a343a0b7)

[offamitkumar]

/approval request test failure (PrivateInvokeTest.java) is still there jdk23u. This is trivial test fix with low risk. Tested on s390x.

[openjdk]

@offamitkumar
8336012: The approval request has been created successfully.

[offamitkumar]

/integrate

[openjdk]

@offamitkumar
Your change (at version a343a0b) is now ready to be sponsored by a Committer.

[offamitkumar]

Hi,
Can I get a sponsor for this clean-backport ?

[phohensee]

/sponsor

[openjdk]

Going to push as commit 9101cc1.
Since your change was applied there have been 5 commits pushed to the master branch:

• cb43c26: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
• 38dc6db: 8319947: Recursive lightweight locking: s390x implementation
• 1d258ba: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR
• d620426: 8340586: JdkJfrEvent::get_all_klasses stores non-strong oops in JNI handles
• 37c05c0: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @offamitkumar Pushed as commit 9101cc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.