Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8339892: Several security shell tests don't set TESTJAVAOPTS #225

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 13, 2024

Hi all,

This pull request contains a backport of commit 8a2a75e5 from the openjdk/jdk repository.

The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339892 needs maintainer approval

Issue

  • JDK-8339892: Several security shell tests don't set TESTJAVAOPTS (Sub-task - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/225/head:pull/225
$ git checkout pull/225

Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.org/jdk23u.git pull/225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 225

View PR using the GUI difftool:
$ git pr show -t 225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/225.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8a2a75e56de4497da48f43b3be3eb71bf3ef75ab 8339892: Several security shell tests don't set TESTJAVAOPTS Nov 13, 2024
@openjdk
Copy link

openjdk bot commented Nov 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2024

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 2 failures

  1. macos-aarch64 job at install toolchain and dependencies stage fails invalid developer directory seems like environmental issue, it's unreleated to this issue.
  2. windows-x64 job jtreg test java/util/zip/ZipFile/ZipSourceCache.java fails The process cannot access the file because it is being used by another process seems like environmental issue or test bug, it's unreleated to this issue.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make several shell tests recevie 'TESTJAVAOPTS' args, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Nov 14, 2024

@sendaoYan
8339892: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 14, 2024
@sendaoYan
Copy link
Member Author

jdk23u repo seems not needed to backport.

@sendaoYan sendaoYan closed this Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant