Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@Vanitha-bp
Copy link
Contributor

@Vanitha-bp Vanitha-bp commented Jul 15, 2024

It is a clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325525 needs maintainer approval

Issue

  • JDK-8325525: Create jtreg test case for JDK-8325203 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk23u.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/24.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2024

👋 Welcome back Vanitha-bp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2024

@Vanitha-bp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325525: Create jtreg test case for JDK-8325203

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e4d80b1: 8334123: log the opening of Type 1 fonts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 81a0d1ba03bbdbe718302b3925cdc207d5d05232 8325525: Create jtreg test case for JDK-8325203 Jul 15, 2024
@openjdk
Copy link

openjdk bot commented Jul 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 15, 2024

⚠️ @Vanitha-bp This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2024

Webrevs

@Vanitha-bp
Copy link
Contributor Author

Vanitha-bp commented Jul 15, 2024

/approval JDK-8325525 request Backporting bug to 23u for test coverage improvement, test-only fix, no risk

@openjdk
Copy link

openjdk bot commented Jul 15, 2024

@Vanitha-bp
JDK-8325525: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 15, 2024
@openjdk
Copy link

openjdk bot commented Jul 16, 2024

⚠️ @Vanitha-bp the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8325203
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 16, 2024
@Vanitha-bp
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 16, 2024
@openjdk
Copy link

openjdk bot commented Jul 16, 2024

@Vanitha-bp
Your change (at version 4878084) is now ready to be sponsored by a Committer.

@Vanitha-bp
Copy link
Contributor Author

@coffeys Can you please sponsor the changes?

@coffeys
Copy link
Contributor

coffeys commented Jul 17, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 17, 2024

Going to push as commit 8883b15.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e4d80b1: 8334123: log the opening of Type 1 fonts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2024
@openjdk openjdk bot closed this Jul 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@coffeys @Vanitha-bp Pushed as commit 8883b15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants