8321509: False positive in get_trampoline fast path causes crash

[lutkerd]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8321509 needs maintainer approval

Issue

• JDK-8321509: False positive in get_trampoline fast path causes crash (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jdk23u.git pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/36.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321509: False positive in get_trampoline fast path causes crash

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• c40246c: 8336692: Redo fix for JDK-8284620
• 950de65: 8335904: Fix invalid comment in ShenandoahLock
• d07767c: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
• a523870: 8335237: ubsan: vtableStubs.hpp is_vtable_stub exclude from ubsan checks
• 9704054: 8334564: VM startup: fatal error: FLAG_SET_ERGO cannot be used to set an invalid value for NonNMethodCodeHeapSize
• 91d6d15: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• 1db2bb0: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
• b5df571: Merge
• 2288c05: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
• 5473e9e: 8325280: Update troff manpages in JDK 23 before RC
• ... and 36 more: https://git.openjdk.org/jdk23u/compare/6ad484a475a5291034558864ab6f5611a90c825a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @lutkerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (1d430234)

[lutkerd]

/approval request Backporting at jdk21u maintainer request.

[openjdk]

@lutkerd
8321509: The approval request has been created successfully.

[lutkerd]

/integrate

[openjdk]

@lutkerd
Your change (at version 1d43023) is now ready to be sponsored by a Committer.

[benty-amzn]

/sponsor

[openjdk]

Going to push as commit cfbc041.
Since your change was applied there have been 46 commits pushed to the master branch:

• c40246c: 8336692: Redo fix for JDK-8284620
• 950de65: 8335904: Fix invalid comment in ShenandoahLock
• d07767c: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
• a523870: 8335237: ubsan: vtableStubs.hpp is_vtable_stub exclude from ubsan checks
• 9704054: 8334564: VM startup: fatal error: FLAG_SET_ERGO cannot be used to set an invalid value for NonNMethodCodeHeapSize
• 91d6d15: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• 1db2bb0: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
• b5df571: Merge
• 2288c05: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
• 5473e9e: 8325280: Update troff manpages in JDK 23 before RC
• ... and 36 more: https://git.openjdk.org/jdk23u/compare/6ad484a475a5291034558864ab6f5611a90c825a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@benty-amzn @lutkerd Pushed as commit cfbc041.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.