Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 31, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334618 needs maintainer approval

Issue

  • JDK-8334618: ubsan: support setting additional ubsan check options (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.org/jdk23u.git pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/49.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334618: ubsan: support setting additional ubsan check options

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 474db8d: 8333754: Add a Test against ECDSA and ECDH NIST Test vector
  • c3d1568: 8328723: IP Address error when client enables HTTPS endpoint check on server socket
  • 1e1e597: 8330702: Update failure handler to don't generate Error message if cores actions are empty
  • 659b469: 8334166: Enable binary check
  • cfbc041: 8321509: False positive in get_trampoline fast path causes crash
  • c40246c: 8336692: Redo fix for JDK-8284620
  • 950de65: 8335904: Fix invalid comment in ShenandoahLock
  • d07767c: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport efb905e57ab7a5299952419fa9961316541056c2 8334618: ubsan: support setting additional ubsan check options Jul 31, 2024
@openjdk
Copy link

openjdk bot commented Jul 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 1, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Aug 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

Going to push as commit e008338.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 6534917: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
  • 0a86e83: 8337819: Update GHA JDKs to 22.0.2
  • 474db8d: 8333754: Add a Test against ECDSA and ECDH NIST Test vector
  • c3d1568: 8328723: IP Address error when client enables HTTPS endpoint check on server socket
  • 1e1e597: 8330702: Update failure handler to don't generate Error message if cores actions are empty
  • 659b469: 8334166: Enable binary check
  • cfbc041: 8321509: False positive in get_trampoline fast path causes crash
  • c40246c: 8336692: Redo fix for JDK-8284620
  • 950de65: 8335904: Fix invalid comment in ShenandoahLock
  • d07767c: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2024
@openjdk openjdk bot closed this Aug 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@MBaesken Pushed as commit e008338.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant