8334166: Enable binary check

[robm-openjdk]

Enable binary check on jdk23u

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8334166 needs maintainer approval

Issue

• JDK-8334166: Enable binary check (Bug - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.org/jdk23u.git pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/52.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back robm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robm-openjdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334166: Enable binary check

Reviewed-by: shade, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[robm-openjdk]

/integrate

[openjdk]

@robm-openjdk This pull request has not yet been marked as ready for integration.

[mlbridge]

Webrevs

• 00: Full (6823f87e)

[shipilev]

I am a bit confused here. Do we really want this for 23u?

I understand this for mainline: it gates addition of new changesets that have binaries in them. But for update releases repos, that might effectively block a backport that pick up a changeset done before a related check was introduced in mainline?

[kevinrushforth]

This is merely an informational warning for the benefit of reviewers. It is not blocking, so yes, I do think we want this for jdk23u (and everywhere else we can backport it to).

[shipilev]

This is merely an informational warning for the benefit of reviewers. It is not blocking, so yes, I do think we want this for jdk23u (and everywhere else we can backport it to).

Oh, it's a warning. Okay then, thanks!

[irisclark]

Thanks for enabling this review-time warning!

[robm-openjdk]

/integrate

[openjdk]

Going to push as commit 659b469.

[openjdk]

@robm-openjdk Pushed as commit 659b469.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.