Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8336928: GHA: Bundle artifacts removal broken #61

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Aug 8, 2024

Fix of GHA code which removes bundle artifacts.

Testing in GHA:
bundles-* artifacts got correctly removed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336928 needs maintainer approval

Issue

  • JDK-8336928: GHA: Bundle artifacts removal broken (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/61/head:pull/61
$ git checkout pull/61

Update a local copy of the PR:
$ git checkout pull/61
$ git pull https://git.openjdk.org/jdk23u.git pull/61/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 61

View PR using the GUI difftool:
$ git pr show -t 61

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/61.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@zzambers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336928: GHA: Bundle artifacts removal broken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0a86e83: 8337819: Update GHA JDKs to 22.0.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 98562166e4a4c8921709014423c6cbc993aa0d97 8336928: GHA: Bundle artifacts removal broken Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 8, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2024

Webrevs

@zzambers
Copy link
Contributor Author

zzambers commented Aug 8, 2024

/approval request Fix of GHA code which removes bundle artifacts, only affects testing in GHA, testing OK

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@zzambers
8336928: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 8, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Aug 8, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@zzambers
Your change (at version b784515) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

Going to push as commit 66fb62a.
Since your change was applied there have been 3 commits pushed to the master branch:

  • e008338: 8334618: ubsan: support setting additional ubsan check options
  • 6534917: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
  • 0a86e83: 8337819: Update GHA JDKs to 22.0.2

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2024
@openjdk openjdk bot closed this Aug 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 12, 2024
@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@shipilev @zzambers Pushed as commit 66fb62a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants