8337876: [IR Framework] Add support for IR tests with @Stable

[shipilev]

Clean backport to improve IR Framework for upcoming tests.

Additional testing:

• MacOS AArch64 server fastdebug, testlibrary_tests/ir_framework passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8338112 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8337876 needs maintainer approval

Issues

• JDK-8337876: [IR Framework] Add support for IR tests with @Stable (Enhancement - P4 - Approved)
• JDK-8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build (Bug - P4 - Approved)

Reviewers

• Evgeny Astigeevich (@eastig - Author)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/62/head:pull/62
$ git checkout pull/62

Update a local copy of the PR:
$ git checkout pull/62
$ git pull https://git.openjdk.org/jdk23u.git pull/62/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 62

View PR using the GUI difftool:
$ git pr show -t 62

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/62.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337876: [IR Framework] Add support for IR tests with @Stable
8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build

Reviewed-by: eastigeevich, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• a21db48: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds
• 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 02: Full - Incremental (fd254946)
• 01: Full - Incremental (7ef846f3)
• 00: Full (4abef48d)

[shipilev]

/approval request Clean backport to improve IR Framework for upcoming tests. Applies cleanly. IR Framework tests pass. Risk is low: test infrastructure change.

[openjdk]

@shipilev
8337876: The approval request has been created successfully.

[shipilev]

/issue add JDK-8338112

[openjdk]

@shipilev
Adding additional issue to issue list: 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build.

[shipilev]

/approval 8338112 request Follow-up for 8337876 to fix the test in release builds. Applies cleanly. Release JDK passes the test. Risk is low, test-only change.

[openjdk]

@shipilev
8338112: The approval request has been created successfully.

[bridgekeeper]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Both backports are actually clean. The PR is not marked clean because we have two bugs references in it.

/clean

[openjdk]

@shipilev The /clean pull request command is not enabled for this repository

[shipilev]

@shipilev The /clean pull request command is not enabled for this repository

:( Need some reviews then, please.

[eastig]

Confirming it's a clean backport.

[shipilev]

Thank you!

/integrate

[openjdk]

Going to push as commit 5979904.
Since your change was applied there have been 5 commits pushed to the master branch:

• 547a229: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• a21db48: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds
• 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 5979904.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.