Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.
/ jdk23u Public archive

8338286: GHA: Demote x86_32 to hotspot build only#79

Closed
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8338286-demote-x86-32
Closed

8338286: GHA: Demote x86_32 to hotspot build only#79
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8338286-demote-x86-32

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Aug 20, 2024

This should make GHAs cleaner and more efficient for future backports.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338286 needs maintainer approval

Issue

  • JDK-8338286: GHA: Demote x86_32 to hotspot build only (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/79/head:pull/79
$ git checkout pull/79

Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.org/jdk23u.git pull/79/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 79

View PR using the GUI difftool:
$ git pr show -t 79

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/79.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338286: GHA: Demote x86_32 to hotspot build only

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 3e84510: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • 447800f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
  • 3988420: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • be9b43c: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option
  • 5c32f21: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743
  • a4dcbb3: 8335743: jhsdb jstack cannot print some information on the waiting thread
  • 403fa37: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment
  • a67b103: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058
  • 0cf6cc3: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
  • d03c704: 8338110: Exclude Fingerprinter::do_type from ubsan checks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport da7311bbe37c2b9632b117d52a77c659047820b7 8338286: GHA: Demote x86_32 to hotspot build only Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request This should make GHAs cleaner and more efficient for future backports. Applies cleanly. GHA works. Risk is low: test infrastructure change.

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@shipilev
8338286: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 21, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

Going to push as commit bf77a6c.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 069283b: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test
  • 3e84510: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • 447800f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
  • 3988420: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • be9b43c: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option
  • 5c32f21: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743
  • a4dcbb3: 8335743: jhsdb jstack cannot print some information on the waiting thread
  • 403fa37: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment
  • a67b103: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058
  • 0cf6cc3: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
  • ... and 1 more: https://git.openjdk.org/jdk23u/compare/2369d92f5f51a0f2aa290d9e5af9e12a3a2dc621...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 27, 2024
@openjdk openjdk bot closed this Aug 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 27, 2024
@openjdk
Copy link

openjdk bot commented Aug 27, 2024

@shipilev Pushed as commit bf77a6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant

Comments