Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jdk23u Public archive

8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test #82

Closed
wants to merge 1 commit into from

Conversation

Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Aug 22, 2024

This is a manual test. Here are the run results:-

/Users/dk-23.0.1.jdk/Contents/Home/bin/java -cp . Password
Two passwords will be prompted for. The first one should have echo off, the second one on. Otherwise, this test fails
Invisible:
Visible: hello
You input hello and hello


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335172 needs maintainer approval

Issue

  • JDK-8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/82/head:pull/82
$ git checkout pull/82

Update a local copy of the PR:
$ git checkout pull/82
$ git pull https://git.openjdk.org/jdk23u.git pull/82/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 82

View PR using the GUI difftool:
$ git pr show -t 82

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/82.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3e84510: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • 447800f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Aug 22, 2024
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2024
@Shivangi-aa
Copy link
Author

/approval JDK-8335172 request Backport to 23, test fix

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@Shivangi-aa
JDK-8335172: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 22, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 26, 2024
@Shivangi-aa
Copy link
Author

/integrate auto

@Shivangi-aa
Copy link
Author

@coffeys Please sponsor this change

@openjdk openjdk bot added the auto label Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@Shivangi-aa This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@openjdk[bot]
Your change (at version 89bb9e3) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Aug 26, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

Going to push as commit 069283b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 3e84510: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • 447800f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2024
@openjdk openjdk bot closed this Aug 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@coffeys @Shivangi-aa Pushed as commit 069283b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants