-
Notifications
You must be signed in to change notification settings - Fork 62
8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test #82
Conversation
👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into |
@Shivangi-aa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval JDK-8335172 request Backport to 23, test fix |
@Shivangi-aa |
/integrate auto |
@coffeys Please sponsor this change |
@Shivangi-aa This pull request will be automatically integrated when it is ready |
/integrate |
/sponsor |
Going to push as commit 069283b.
Your commit was automatically rebased without conflicts. |
@coffeys @Shivangi-aa Pushed as commit 069283b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a manual test. Here are the run results:-
/Users/dk-23.0.1.jdk/Contents/Home/bin/java -cp . Password
Two passwords will be prompted for. The first one should have echo off, the second one on. Otherwise, this test fails
Invisible:
Visible: hello
You input hello and hello
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/82/head:pull/82
$ git checkout pull/82
Update a local copy of the PR:
$ git checkout pull/82
$ git pull https://git.openjdk.org/jdk23u.git pull/82/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 82
View PR using the GUI difftool:
$ git pr show -t 82
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/82.diff
Webrev
Link to Webrev Comment