-
Notifications
You must be signed in to change notification settings - Fork 62
8337780: RISC-V: C2: Change C calling convention for sp to NS #87
8337780: RISC-V: C2: Change C calling convention for sp to NS #87
Conversation
👋 Welcome back fyang! A progress list of the required criteria for merging this PR into |
@RealFYang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. This is a RISC-V specific change. Tier1-3 tested on linux-riscv64 platform. |
@RealFYang |
/integrate |
Going to push as commit 7bdece3. |
@RealFYang Pushed as commit 7bdece3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. Gtest & Tier1-3 tested on linux-riscv64 platform.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/87/head:pull/87
$ git checkout pull/87
Update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.org/jdk23u.git pull/87/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 87
View PR using the GUI difftool:
$ git pr show -t 87
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/87.diff
Webrev
Link to Webrev Comment